Aleksei Savartsov

Hi! I stumbled into RNBO C++ export can't really be compiled with 

define. I think why is pretty much obvious: just not all parts of code that work with presets are  guarded with this flag and there are also some incomplete types. More specifically, I use

 Maybe it sounds not a big deal but disabling presets completely saves around 8KB of code space on my target (comparing to  RNBO_NOJSONPRESETS flag). So maybe it could be fixed 🙏 

Here is the patch I'm using now, quite simple changes there:

Subject: [PATCH] RNBO_NOPRESETS
---
Index: src/RNBO_Presets.h
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/RNBO_Presets.h b/src/RNBO_Presets.h
--- a/src/RNBO_Presets.h	(revision f04b93be2bc9a4883cea1c95e4c17603d94e2932)
+++ b/src/RNBO_Presets.h	(date 1711830792375)
@@ -12,9 +12,10 @@
 #ifdef RNBO_NOPRESETS

 namespace RNBO {
-	using Preset = PatcherState;
+	using Preset = void*;
 	using PresetCallback = void(*);
 	using UniquePresetPtr = void*;
+	using ConstPresetPtr = void;
 }

 #else
Index: src/RNBO_EngineCore.h
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/RNBO_EngineCore.h b/src/RNBO_EngineCore.h
--- a/src/RNBO_EngineCore.h	(revision f04b93be2bc9a4883cea1c95e4c17603d94e2932)
+++ b/src/RNBO_EngineCore.h	(date 1711830902727)
@@ -610,23 +610,29 @@

 		virtual void setPresetSync(UniquePresetPtr preset)
 		{
-			_settingPreset = true;
+#ifndef RNBO_NOPRESETS
+  			_settingPreset = true;
 			sendOutgoingEvent(PresetEvent(_currentTime, PresetEvent::SettingBegin));
 			_patcher->setPreset(_currentTime, *preset);
 			sendOutgoingEvent(PresetEvent(_currentTime, PresetEvent::SettingEnd));
 			_settingPreset = false;
+#endif
 		}

 		virtual ConstPresetPtr getPresetSync() {
+#ifndef RNBO_NOPRESETS
 			PresetPtr preset = std::make_shared<Preset>();
 			_patcher->getPreset(*preset);
 			return preset;
+#endif
 		}

 		void presetTouched() override {
+#ifndef RNBO_NOPRESETS
 			if (!_settingPreset) {
 				sendOutgoingEvent(PresetEvent(_currentTime, PresetEvent::Touched, nullptr, nullptr));
 			}
+#endif
 		}

 		virtual void beginProcessDataRefs() {}
Index: src/RNBO_ParameterInterfaceSync.cpp
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/RNBO_ParameterInterfaceSync.cpp b/src/RNBO_ParameterInterfaceSync.cpp
--- a/src/RNBO_ParameterInterfaceSync.cpp	(revision f04b93be2bc9a4883cea1c95e4c17603d94e2932)
+++ b/src/RNBO_ParameterInterfaceSync.cpp	(date 1711830924705)
@@ -52,6 +52,7 @@
 		}

 		if (event.isPresetEvent()) {
+#ifndef RNBO_NOPRESETS
 			PresetEvent pe = event.getPresetEvent();
 			if (pe.getType() == PresetEvent::Get) {
 				_engine.handlePresetEvent(pe);
@@ -59,6 +60,7 @@
 			else {
 				_engine.scheduleEvent(event);
 			}
+#endif
 		}
 		else {
 			_engine.scheduleEvent(event);


RNBO C++ export: RNBO_NOPRESETS